Erik Johnston

Results 144 comments of Erik Johnston

> Can we just use a separate ratelimiter for the two checks rather than trying to be "clever" ? I don't follow this? Do you mean not having the `update=False`...

Hi, really sorry for sitting on this for so long. We (empirically) don't have time to really accept large contributions to this project right now, especially as we don't have...

This is when sending the invite, rather than receiving the invite. (Also, the synapse PR hasn't yet landed https://github.com/matrix-org/synapse/pull/4721 )

> > I would like to add another solution. **State keys could be of type: `string | string[]`** Where `state_key: string = "hello"` is a shortcut for `state_key: string[] =...

It feels like this is a fairly useful thing to support, with no great alternative way of doing it in the short/medium term. @mscbot fcp merge

https://github.com/element-hq/synapse/pull/17228 was a quick attempt to address this. The approach was to basically add a mounted directory to the python path, and then doing `pip install -t ` to install...

Oh bleurgh, the typing stream can legitimately go backwards :roll_eyes:

Right, so the problem is that there are occasions where we ask for a new stream ID from the generator, but then don't persist it in the DB. If this...

> I'm not quite sure what the right way forward is her here, ideally we'd make it so that stream IDs _must_ be used, but that is hard. Actually, maybe...

> > I'm not quite sure what the right way forward is her here, ideally we'd make it so that stream IDs _must_ be used, but that is hard. >...