Erik Hermansen

Results 27 comments of Erik Hermansen

@DenisCarriere I just got done doing the "new project" setup stuff, and am digging into polygonSlice(). A thing that confuses me with the current implementation is that it returns a...

Okay, thanks, that makes sense. I just wanted to make sure I wasn't missing something in what the function was supposed to do.

To give a concrete example of how a loop guard could work... ``` module.exports = function subdivide(eventQueue, subject, clipping, sbbox, cbbox, operation) { ...stuff... var eventQueueGuard = createLoopGuard(10000, 'subdivide() event...

Thanks for the feedback. I have it working and will post a PR tomorrow. Yes, the loop check is very minimal (basically just ´´´if (++iterationCount > maxAllowed) throw```). It will...

@HansBrende could you connect with me on LinkedIn - https://www.linkedin.com/in/erikhermansen/ ? I can answer your question better there.

Another case that produces a similar result--this one has no intersection between the two shapes. Green shape is first argument, blue is second. It's necessary to call ```union()``` (```diff()``` with...

@rowanwins I'm happy to try it. Do you have PR# so I can see which changes to undo? I looked through the PRs a bit, and it wasn't obvious to...

Ah, I already didn't have #56 merged in. I was going to take a crack at making a fix, but it feels like the PRs are piling up a bit,...

**Update:** I don't think the current implementation is coded to handle the case of holes created by exterior ring edges. Inside of ```connectEdges()```, there is this code for creating interior...

Okay, cool. I'll put a PR together.