ann-benchmarks icon indicating copy to clipboard operation
ann-benchmarks copied to clipboard

Add benchmark for n-dimensional khash (from UCX)

Open alex--m opened this issue 3 years ago • 4 comments

Based on the new n-dimensional ANN lookup implemented in UCX (based on khash).

alex--m avatar Oct 23 '21 22:10 alex--m

Thanks for the contribution. I am a bit unsure how this is supposed to work, where will the *. so file come from? Please provide a dockerfile in install/ and add your implementation to CI in .github/ to see if it works. Thanks!

maumueller avatar Oct 24 '21 05:10 maumueller

@maumueller Yes, there are some open technical issues, and that's why I've submitted it as a "draft PR". To clarify, this runs on my machines, but the best way to go is to only merge this after UCX accepts the implementation code upstream (may take a while...) - then this libucs_ann_search.so is distributed as part of the UCX installation (in a container). The reason I did create this PR (aside from future reference) is for the UCX community to see and play with evaluating the performance of this ANN implementation, to convince them to accept it).

alex--m avatar Oct 24 '21 08:10 alex--m

@alex--m: Thanks for the explanation. Looking forward to the progress.

maumueller avatar Oct 25 '21 06:10 maumueller

I agree with @maumueller – I think it should come with a proper Dockerfile

erikbern avatar Oct 25 '21 13:10 erikbern