SwiftPrivilegedHelper icon indicating copy to clipboard operation
SwiftPrivilegedHelper copied to clipboard

Enclosing the team identifier with double quotations

Open tnake opened this issue 5 years ago • 3 comments

Thank you for your work. I use this project in my product. I encounter an issue that I can not execute my product expectedly, so that I report that issue.

I can execute my product correctly in the mode of Debug, whereas I could not execute my product which is exported from Organizer(which do Archive of product). I've investigate Info.plist, Helper-Info.plist, and CodeSignUpdate.sh, then I've had a doubt thing that the string of 'certificate leaf[subject.OU] = MY TEAM IDENTIFIER' is not containing double quotations. I think that above string 'MY TEAM IDENTIFIER' should be enclosing with double quotations. So that, I propose that in line 67 of CodeSignUpdate.sh: printf "%s" "certificate leaf[subject.OU] = ${developmentTeamIdentifier}" replace with printf "%s" "certificate leaf[subject.OU] = \"${developmentTeamIdentifier}\"" (i.e. ${developmentTeamIdentifier} is enclosed with double quotations).

Note that, I use Xcode 11. So, I've applied a workaround(https://github.com/erikberglund/SwiftPrivilegedHelper/issues/19).

tnake avatar Jan 28 '20 01:01 tnake

can confirm this change is needed to build in "Release"

gregcotten avatar Aug 05 '20 05:08 gregcotten

I've reported this issue, in doing Archive. However, doing Archive is the use of 'Release-mode' settings. So you can see probably this issue in Release-mode build. Does this answer your question?

tnake avatar Aug 05 '20 06:08 tnake

I don't have a question - I am agreeing with you!

gregcotten avatar Aug 05 '20 06:08 gregcotten