squabble icon indicating copy to clipboard operation
squabble copied to clipboard

Line-based ignores

Open PhilipTrauner opened this issue 5 years ago • 2 comments

Adds line-based ignores as discussed in #7.

create table customer (
    name text not null,
    -- squabble-disable-next-line
    primary key(name)
);

I didn't bother to write tests for this yet, as I feel that I made some rather substantial changes to the codebase that you might not agree with 😅

Adds the skip attribute to the global config that can either be set through the global configuration, or by the per-file configuration system (which is much more likely).

PhilipTrauner avatar Feb 20 '20 15:02 PhilipTrauner

Nice! Honestly this is a far more minimal change than I was expecting this to take.

I'll give this a proper review later, but after a quick reading I didn't notice any changes that I'd be uncomfortable with.

erik avatar Feb 20 '20 17:02 erik

Have you been able to do a deep dive yet? 🙂 I went over my changes again, and I'm still not sure if modifying the linting machinery, rather than the reporting system was the right call. I wouldn't mind doing a second pass on this, so feel free to be brutally honest 😅

PhilipTrauner avatar Feb 26 '20 18:02 PhilipTrauner