silkworm icon indicating copy to clipboard operation
silkworm copied to clipboard

Block Transaction's From field should be protected

Open AndreaLanfranchi opened this issue 2 years ago • 1 comments

Actually you can set an arbitrary sender address to a transaction (simply providing a value for the optional) but this can lead to data corruption as the provided value might not match the signature of the transaction. To be done : make from a getter function from private field Wrt #660

AndreaLanfranchi avatar May 09 '22 18:05 AndreaLanfranchi

Would this mean that the only way to set the from field is through recover_sender()? If so, won't a lot of test cases need to be re-written? For e.g. this

I don't see the proper values of r, s, v set in some of these tests to be able to recover the sender.

gurukamath avatar May 12 '22 08:05 gurukamath

Done in #1711

canepat avatar Mar 08 '24 07:03 canepat