silkworm
silkworm copied to clipboard
Block Transaction's From field should be protected
Actually you can set an arbitrary sender address to a transaction (simply providing a value for the optional) but this can lead to data corruption as the provided value might not match the signature of the transaction.
To be done : make from
a getter function from private field
Wrt #660
Would this mean that the only way to set the from
field is through recover_sender()
? If so, won't a lot of test cases need to be re-written? For e.g. this
I don't see the proper values of r, s, v set in some of these tests to be able to recover the sender.
Done in #1711