silkrpc icon indicating copy to clipboard operation
silkrpc copied to clipboard

JSON benchmark

Open canepat opened this issue 3 years ago • 1 comments

canepat avatar Jan 26 '22 17:01 canepat

Codecov Report

Merging #226 (505ad91) into master (8975003) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 505ad91 differs from pull request most recent head ac82f70. Consider uploading reports for the commit ac82f70 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #226   +/-   ##
=======================================
  Coverage   80.53%   80.53%           
=======================================
  Files          82       82           
  Lines        3864     3864           
=======================================
  Hits         3112     3112           
  Misses        752      752           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8975003...ac82f70. Read the comment docs.

codecov[bot] avatar Jan 26 '22 17:01 codecov[bot]

The technical path explored in this PR was valuable in terms of performance gains (not game-changing, though) but at the cost of cluttering the code base a lot.

Hence, I'm closing this for now. We can reopen it in the future if/when we will need to focus on improving JSON encoding/decoding performance.

canepat avatar Jan 24 '23 21:01 canepat