Style/type cleanup

[Paril]

This is just a draft that will be in progress for a while, and is meant to be the "cleaned up"/refactored branch. Please drop any opinions of the cleanup progress.

This branch is based on qbsp-contentflags.

---

Todo May 2022:

qbsp:

• [ ] -xwadpath / -wadpath should always parse exactly 1 directory following the switch, so they can be used as the last switch before the map and optional bsp file on the command line
• [ ] when using -xwadpath or -notex, don't warn about missing textures at the end of the qbsp output

---

Eric: TODO: (old)

• [x] fix q2 clip
• [x] fix q2 detail
• [ ] test q1 fence/glass shadow casting
  • [ ] also check _light_alpha for liquids (projection of the water texture)
• [x] fix q1 outside filling
• [x] fix base1.map leak
• [ ] ad_grendel.map fails with CheckFace: line 0: coordinate out of range (65552)
• [x] Automatic switching from Q1 BSP29 to BSP2 is broken - map has entdata size 1, 0 planes, 0 vertexes. Using -bsp2 switch fixes the problem, so it's something with the exception handling in ConvertBSPFormat, probably.
  • [ ] add test
• [ ] check: did light/vis etc. previously accept a .map file on the command line, and automatically switch to the corresponding .bsp file? (e.g. vis something.map acts as if you did vis something.bsp) If so we'll want to preserve that behaviour
• [x] ASan failures:
  • [x] vis -nostate -threads 1 qbsp_angled_brush.bsp
  • [x] leaks reported on Ubuntu (some fixed, nontrivial to fix all right now)
• [x] make automated_tests.sh easier to run in IDE (move to CTest?)
• [x] see if anything can be done about build times
• [x] add test for q2 detail
• [x] fix qbsp_tjunc_many_sided_face.map glitch, bisected to https://github.com/ericwa/ericw-tools/commit/a6f6cc2d150493b899886040e170527195e81ab5
• [ ] fix qbsp_leaf_contents_bug.map
• [ ] fix shib8 issues
• [ ] q1 skip doesn't seem to seal? (test case: hollow box made of skip with info_player_start inside)