Eric Snow comments

Results 247 comments of


                                            Eric Snow

Mark 3.12 PEPs as Final

Regarding PEP 687, you can see the implementation status on https://github.com/python/cpython/issues/103092. Only the faulthandler module is left and I'm not sure that's worth waiting to mark the PEP as final.

PyCapsule_Import fails when name is in the form 'package.module.capsule'

+1 on using ":" as the separator.

extend `sys` module on windows

Is `sys.implementation` the right place? It should have things related only to the Python implementation, that other implementations also have. The architecture is a build characteristic and the api partitions...

extend `sys` module on windows

`sys._build.*`?

extend `sys` module on windows

My main concern was/is that this information doesn't belong on `sys.implementation`. That's meant for information about the Python *implementation* (e.g. cpython, pypy, jython, micropython), not about the *build*. See [PEP...

destroy_gil() is not called over multiple Py_Initialize() / Py_Finalize() calls

Thanks for the detailed analysis (and PR), @adr26! I'll take a look.

destroy_gil() is not called over multiple Py_Initialize() / Py_Finalize() calls

@adr26, I started taking a look at this, but realized that there have been quite a few changes in this area recently for the free-threading build. Could you take a...