SQLitePCL.raw icon indicating copy to clipboard operation
SQLitePCL.raw copied to clipboard

Enable new math functions?

Open bricelam opened this issue 3 years ago • 9 comments

Looks like there are some new math functions in SQLite 3.35.0. Should we add SQLITE_ENABLE_MATH_FUNCTIONS to the list of default defines?

https://github.com/ericsink/cb/blob/bd3ec0643c5297c05c765f04a28104e85b59dd0c/bld/cb.cs#L1065-L1072

bricelam avatar May 04 '21 18:05 bricelam

When I try integrating 3.35.x (soon), I do plan to try turning that on to see how it goes.

ericsink avatar May 04 '21 18:05 ericsink

(But I'm glad you logged this so we have a place to track status of the issue)

ericsink avatar May 04 '21 18:05 ericsink

Would be great to get this enabled in the next release. The CEILING function is desperately needed and shouldn't be excluded from the standard build IMO (though that's a quirk of SQLite not SQLitePCLRaw)

nbevans avatar Dec 18 '22 17:12 nbevans

Any chance of it @ericsink ?

I may be naive of what goes on in the SQLitePCL.raw lib builds but it seems highly unlikely that enabling this compile-time option would break anything?

The math functions are included in most builds of SQLite now but not SQLitePCL.raw yet :(

nbevans avatar May 03 '23 17:05 nbevans

Hmmm. That looks like it would be fairly straightforward to include those.

I'll take a look soon. A few things have piled up, and it seems like time to crank out another release.

ericsink avatar May 03 '23 17:05 ericsink

I had trouble getting the Android builds to link with the math libs, so for now, I released 2.1.5 without this fix, so I can get the Mac arm64 simulator support out there. Hopefully 2.1.6 with math functions will follow shortly.

ericsink avatar May 19 '23 20:05 ericsink

Just to remind myself and others about this issue: I've been a bit swamped, and still haven't figured out the problem with math libs linking on android.

ericsink avatar Jun 07 '23 18:06 ericsink

I got the CI passing in https://github.com/ericsink/cb/pull/17!

bricelam avatar Jul 25 '23 19:07 bricelam

Yay!

So it looks like the basic fix was to up the android API level higher.

Thanks!

ericsink avatar Jul 25 '23 19:07 ericsink