Eric Riff

Results 61 comments of Eric Riff

Interesting, I tried a couple of combinations before opening this PR and also yo tried some and reported it was fine. It looks like a combination slipped through the cracks....

@uilianries which cmd have you used for your build? You did not attach the logs properly so I can't see it. I tried before a few combinations and all passed....

I had to add a patch since this is a problem on the behaviorcppp side. As you stated that binary uses zeromq directly (instead of the cppzmq wrapper), but it...

I thought about it. But then I would have to wait for it to be reviewed, approved, merged and then wait for another release cycle. I was planning on sending...

I found that this library has 4 more vendored libraries, in another subfolder. I'll open another PR upstream for them. I'll park this PR for now. https://github.com/BehaviorTree/BehaviorTree.CPP/tree/master/include/behaviortree_cpp/contrib

@uilianries what do you think about this discussion? https://github.com/BehaviorTree/BehaviorTree.CPP/issues/1025#issuecomment-3432382511

So I did some more digging. Even though the patch I pushed here works, it is not the proper solution. The problem is that on my PR to un-vendor the...

Hey @nyibbang, lets ping @uilianries. Maybe this discussion fell through the cracks on his side. Just to reiterate the problem: my original implementation on this PR passes all checks on...

> @ericriff Hello! > > After doing a few new tests, including building BehaviorTree.CPP without this recipe, I think it would be better to keep it as close as possible...

> > Hmm, what's the problem with our package? Maybe it is missing a transitive_libs = True or something? > > Unfortunately, it's a consequence of that PR https://github.com/BehaviorTree/BehaviorTree.CPP/pull/1012/changes#diff-21531137bd51dce0e3ead32b89722f3c98ad44f55df980a951e5ccc88c7664dfR4 >...