ruumba icon indicating copy to clipboard operation
ruumba copied to clipboard

Layout/TrailingWhitespace on every single line

Open brendonrapp opened this issue 4 years ago • 6 comments

test.html.erb

<div>
  <p>Test ERB file</p>
</div>

Ruumba output:

% ruumba -v                                                                                                                                                                                                                
ruumba 0.1.16

% ruumba test.html.erb                                                                                                                                                                                                     
Inspecting 1 file
C

Offenses:

test.html.erb:1:1: C: Layout/TrailingWhitespace: Trailing whitespace detected.
test.html.erb:1:2: C: Layout/TrailingEmptyLines: 2 trailing blank lines detected.
test.html.erb:2:1: C: Layout/TrailingWhitespace: Trailing whitespace detected.
test.html.erb:3:1: C: Layout/TrailingWhitespace: Trailing whitespace detected.

brendonrapp avatar Nov 09 '20 22:11 brendonrapp

@brendonrapp Apologies for the delay on this one; I should have a resolution for you over the weekend at the latest.

ericqweinstein avatar Dec 03 '20 01:12 ericqweinstein

Reproduced, including for files with interpolated Ruby. @brendonrapp could you confirm your version of Ruby as well?

ericqweinstein avatar Dec 08 '20 04:12 ericqweinstein

(My guess is this is a weird interaction between Ruumba and a newer version of RuboCop, but it's always good to have more information.) Actually, if you could share your RuboCop version, that'd be helpful, too.

ericqweinstein avatar Dec 08 '20 04:12 ericqweinstein

In the meantime, I'll pin rubocop as > 1.5 in ruumba's Gemfile.

ericqweinstein avatar Dec 08 '20 04:12 ericqweinstein

Note that, as per the README, Layout/TrailingEmptyLines is expected (this cop needs to be disabled pending a future PR).

ericqweinstein avatar Dec 15 '20 22:12 ericqweinstein

@brendonrapp Apologies for the long delay here. My recommendation is to disable this cop pending a fix (which I'll get to as soon as I have some spare cycles).

ericqweinstein avatar Mar 30 '21 00:03 ericqweinstein