Eric Hanson

Results 461 comments of Eric Hanson

the Julia dockerfiles just install the official binaries from s3: https://github.com/docker-library/julia/blob/b755ce872b5ff0a2118840bc787b0832c8710eb6/stable/bookworm/Dockerfile#L42

yeah, might be good. could also check alternative, if provided, is the name of a package in the registry

Maybe we should merge this and open issues for follow-ups?

Regarding the match proposal, having `return` _not_ return from the function seems pretty confusing and can cause bugs when refactoring. Since nothing else works like that (for/if/etc). Could we have...

we do have https://github.com/JuliaTesting/ExplicitImports.jl/blob/main/.pre-commit-hooks.yaml in case you want to use that, fyi. https://github.com/JuliaTesting/ExplicitImports.jl/tree/main?tab=readme-ov-file#pre-commit-hooks

I got it working with https://github.com/JuliaLang/Pkg.jl/pull/4329 but it needs a pre-commit change to support in-repo hooks for julia. So if we want it soon we'd have to move the hooks...

> I changed this to just run on CI. @ericphanson, are these bugs in ExplicitImports: > > ```julia > using UUIDs: UUIDs # used at /Users/kc/JuliaPkgs/Pkg.jl/src/REPLMode/REPLMode.jl:8:7 > > using Dates:...

adding to this, I think the `api` command itself should not be hidden, xref https://github.com/JuliaLang/juliaup/pull/1138#issuecomment-3319422870. Though that is separate to whether or not the subcommands are documented (which I think...

For me, `.args` just became `.children`: https://github.com/JuliaTesting/ExplicitImports.jl/pull/110/files#diff-b8efdab12511a421cb933fefe9c2f24ee91d19cca2ed0cec7469f7a60b6ad750R371