Eric Hanson

Results 342 comments of Eric Hanson
trafficstars

Having some issues improving accuracy using lowered code: - hard to get top-level info as discussed above. This also applies to function arguments, so using lowered information here doesn't seem...

Interesting, looks useful. I was thinking that getting these checks into Aqua.jl could be the “distribution” method since it’s already commonly used (and there’s probably a GitHub action for it)....

closed by #433?

What about naming this `compat current`, and then here could also be a `compat latest` to set the bounds to the latest version? And maybe it could work with individual...

> In the case of subpackages, we can have an optional git-tree-path giving the path in the commit/tag to the corresponding tree. We do have `subdir` that is similar but...

Yeah, maybe `subdir` should just move to be per version? Or have both for awhile until all supported Pkg’s know the new location

> This all sound a lot like the `[features]` support of `Cargo.toml` (https://doc.rust-lang.org/cargo/reference/features.html). I think it's design is pretty functional. Maybe, we could look at it for an idea of...

I'm also seeing no coverage showing up, with v1.127.2 of the extension.

I think that makes sense. One thing that might make this easier is a new label: https://github.com/JuliaRegistries/RegistryCI.jl/pull/573 However that can work in addition to changing the default.

this seems reasonable to me; probably we should treat them like submodules?