Eric P Green
Eric P Green
Thanks for the fix! The core issue makes sense - `cmd/ctrl+click` on links in embedded iframes doesn't work as expected. The implementation works, but I wanted to share some thoughts...
Here's where we can continue the discussion of the longer-term refactor: https://github.com/rilldata/rill/pull/8502
> I believe this is a known CORS issue in local dev. Are you sure? My avatar renders correctly in the top-right.
Clicking the "invite" button doesn't do anything for me here: [Jam](https://jam.dev/c/708b6b09-9fa5-41e1-9736-6279f183c929)
> @ericpgreen2 slight change to our Viz for AI. We will pick a theme of it has been defined, you think that's too aggressive? I'd advocate for consistency. Since Explore...
> @ Eric Green I noticed the ExploreChat component was added to layout.svelte and was outside the Dashboard component. I have now put the ExploreChat component inside Dashboard.svelte. As such...
> @ericpgreen2 : Is it ready to be reviewed? Ready now!
I like the idea of using Turbo & I can see the benefit of creating smaller packages to improve its ability to cache. One reservation I have is that if...
@lovincyrus, given your ownership of the connector forms, can you please do the first frontend reviews of this code? For now, I've removed myself as reviewer and tagged you. Once...
## Review: Architecture Feedback on Rich Text Rendering Hi! While reviewing the changes, I noticed an architectural issue with how we're rendering user messages that we should discuss. --- ###...