Eric Ma

Results 388 comments of Eric Ma

> Just wanted to confirm, for the second method style, how would you "transform" multiple columns when you want to rename some columns but not the other? (That's the main...

@sallyhong I like what you've done there! I am also wondering, what if the default suffix was not a fixed label, but instead the `__name__` attribute of the function passed...

Looking into it on a branch. Starting with a mypy configuration file. I'm not quite sure what to look for here, though, and hence what to enforce in CI. What...

Thanks @VPerrollaz for going through the codebase! > I also saw in a few places (11 times in functions.py to be pedantic) arguments annotated with str but initialized to None,...

w.r.t. type annotations, I haven't been insistent as one might desire, because I was in the process of learning about it too. Gradually typing the codebase as we go along...

@VPerrollaz that's a good catch! I can't seem to think of a good reason why we would make it `None` and then check to see if it is None, when...

> First of all I'm definitely interested in joining, but given how little experience I have with such project I'm not sure how much help I would be so let...

@VPerrollaz this all sounds great. Thank you for taking the initiative! I definitely wouldn't have been able to handle it on my own. Would you be open to putting in...

@VPerrollaz just wanted to tighten up loose ends here, and I'd love to have your input here: What's do you think should happen next to close out this issue? I've...

@VPerrollaz got it, I see the concerns you have there. Regardless, I think a PR to `dev` would be great! Here’s how I think we can make it work. 1....