Eric Ma comments

Results 388 comments of


                                            Eric Ma

nxviz <> grave

@tacaswell nice to know you're working with the grave project! I am curious, though how did the name get chosen? It possess quite a bit of, err, gravity. :smile: One...

[ENH] Perf for left/right join when `sort_by_appearance` is False

🚀 Deployed on https://deploy-preview-1170--pyjanitor.netlify.app

[ENH] Perf for left/right join when `sort_by_appearance` is False

LGTM! I'm going to merge.

[ENH] explicit default parameter for case_when

🚀 Deployed on https://deploy-preview-1165--pyjanitor.netlify.app

[ENH] explicit default parameter for case_when

@thatlittleboy would you like to do the honors here? a -0.01% decrease in coverage is marginal, we can handle it :smile:

Update Python to be minimum 3.9

@Zeroto521 I just realized this PR might overlap with your other PR #1143. I'll just use the PR to test some syntax things needed to make Python >=3.8 work. After...

Update Python to be minimum 3.9

🚀 Deployed on https://deploy-preview-1157--pyjanitor.netlify.app

Update Python to be minimum 3.9

Good question, @Zeroto521. Type annotations in Python 3.9 are more flexible, i.e. we can use built-in `tuple` or `list` as types like this: ```python def func(df, arg1: tuple[int]): pass ```...

[ENH/DOC] Support multi-column inputing, `change_type`

When all tests pass, I will hit the merge button :smile:.

Mutation class #57

I am going to do a few more commits to address @andrewgiessel's remaining comments.