Eric Meadows-Jönsson

Results 222 comments of Eric Meadows-Jönsson
trafficstars

If it works well it would be a great improvement so I think it would be worth to try it out. If you would like to send a PR we...

Nice! That looks way better. Can you test if it has an impact on performance? Can you also do the same refactor for `expected_elixir_tags`?

@SteffenDE This looks great thank you. Deploying it to staging to check for performance regressions.

You can check if it's a HTTP/2 connection after ALPN upgrade is done and call the `Mint.HTTP2` functions directly.

What kind of whitespace changes do you want to ignore? We use `git diff` to build the diff, what flags would we pass to it get the expected result? As...

Thanks for the explanation, an option to skip whitespace in diffs definitely seems reasonable to support.

I don't think performance is a big concern here. This check runs every 15min and has plenty other slow parts. Maybe we could parallelize the check for each OS using...

On my machine it doesn't kill the VM, but I do get a `SystemLimitError` exception after a while. In the `ratio/2` implementation https://github.com/ericmj/decimal/blob/v2.1.1/lib/decimal.ex#L1686-L1687, or as a pre-check, we are missing...

Yes, any contributions would be very welcome. Thank you!