Eric Lawrence
Eric Lawrence
The manifest errors are all a result of the fact that the code is the same between Firefox and Chrome.
I suspect this is due to `chrome.safeBrowsingPrivate.getReferrerChain` returning `null` in Edge. Is this something we (Edge) have done wrong, or is this the expected behavior of `getReferrerChain` in browsers without...
This also happens when toggling the "Allow access to file urls" The problem goes away if you use Chrome's DevTools to inspect the background page. So the problem may be...
It may not be relevant for this issue, but it seems like this: ``` chrome.tabs.query({}, (tabs) => { tabs.forEach((tab) => { setBrowserActionAndIcon(tab); }); }); ``` could be safely changed to...
One other oddity; if I inspect the background page while toggling these checkboxes, the |Sources| tab _seems_ to show the background page's script loading multiple times. I don't see this...
Documentation for `chrome.tabs.onActivated` notes that it can fire before `tab.url` is available, so the `setBrowserActionAndIcon` call should probably check whether `tab.url` is assigned before attempting to call `startsWith` on it.
This also reproduces on Mac OSX in Chrome Canary with the official extension. Interestingly, when I build the extension locally and load it "unpacked", the problem does not reproduce.
Blocking the entire domain tree would not be appropriate, because it's effectively a shared space between legitimate and illegitimate subdomains. The request in this issue is to give a "suspiciousness...
crbug.com/1137801 is the relevant issue.
Passing the `dpiaware` argument on Fiddler's command line helps a little, but this doesn't seem to fix everything.