Erick Zhao

Results 246 comments of Erick Zhao

@kristophM I believe that's accurate!

Added some clarity to the documentation around this: https://github.com/electron-forge/electron-forge-docs/commit/c23f806e1b06e36578140c7bce9380b7a20b0ca5

Thanks for these changes @sethcg. I have a few UX tweaks that I would suggest. I think it might be easier if I just push these commits up to your...

Just added commit https://github.com/electron/forge/pull/3933/commits/20823ab9768e25c83a602c4d20aa3aa24b406b6e. * prompt only appears if no flags are passed * changed the prompt to include other initialization options (`skipGit` and `force`) With this change, we lose...

I know certain userland projects have ported the NSIS target on Windows to work with Electron Forge: https://github.com/felixrieseberg/electron-forge-maker-nsis

Thanks for the context @gerardbalaoro! I see VSCode has their own fork as well.

Thanks a million for the additional context @jorangreef! 🙇

Thanks for reporting this @eXhumer! Looks like this is longstanding behaviour in Packager (the `promisifyHooks` function was originally added in electron/packager#753) and Forge, but DEP0174 was recently added as a...

@LY1806620741 I don't think this has an impact on Packager's runtime. If you're running Node.js v21 or higher, they just added a new flag to silence specific warnings. https://nodejs.org/en/blog/release/v21.3.0#new---disable-warning-flag