Eric Fennis
Eric Fennis
@EthanHazel Can you check the linter?
We have a linter for a while now with GH action on PRs. For now, this solves the issue. For now, we don't need this on pre-commit hook
I agree with @karsa-mistmere the other icons should be updated as well.
@karsa-mistmere The right looks better to me.
@karsa-mistmere Nice icon, I like it. Looking at the X-ray, it is a bit shifted relative to the `eye` icon. When using this for example to show/hide something you see...
Sorry, forgot to make it public, [here ya go](https://codesandbox.io/p/devbox/m3r3jj?layout=%257B%2522sidebarPanel%2522%253A%2522EXPLORER%2522%252C%2522rootPanelGroup%2522%253A%257B%2522direction%2522%253A%2522horizontal%2522%252C%2522contentType%2522%253A%2522UNKNOWN%2522%252C%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522id%2522%253A%2522ROOT_LAYOUT%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522UNKNOWN%2522%252C%2522direction%2522%253A%2522vertical%2522%252C%2522id%2522%253A%2522cm0qesp6700073b6jmqcb8zmu%2522%252C%2522sizes%2522%253A%255B70%252C30%255D%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522EDITOR%2522%252C%2522direction%2522%253A%2522horizontal%2522%252C%2522id%2522%253A%2522EDITOR%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL%2522%252C%2522contentType%2522%253A%2522EDITOR%2522%252C%2522id%2522%253A%2522cm0qesp6600023b6jcwmwtrui%2522%257D%255D%257D%252C%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522SHELLS%2522%252C%2522direction%2522%253A%2522horizontal%2522%252C%2522id%2522%253A%2522SHELLS%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL%2522%252C%2522contentType%2522%253A%2522SHELLS%2522%252C%2522id%2522%253A%2522cm0qesp6700043b6j8bqtjdfo%2522%257D%255D%257D%255D%257D%252C%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522DEVTOOLS%2522%252C%2522direction%2522%253A%2522vertical%2522%252C%2522id%2522%253A%2522DEVTOOLS%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL%2522%252C%2522contentType%2522%253A%2522DEVTOOLS%2522%252C%2522id%2522%253A%2522cm0qesp6700063b6jay6yvsj1%2522%257D%255D%257D%255D%252C%2522sizes%2522%253A%255B50%252C50%255D%257D%252C%2522tabbedPanels%2522%253A%257B%2522cm0qesp6600023b6jcwmwtrui%2522%253A%257B%2522tabs%2522%253A%255B%257B%2522id%2522%253A%2522cm0qesp6600013b6jhfwl6bzk%2522%252C%2522mode%2522%253A%2522permanent%2522%252C%2522type%2522%253A%2522FILE%2522%252C%2522filepath%2522%253A%2522%252FREADME.md%2522%252C%2522state%2522%253A%2522IDLE%2522%257D%252C%257B%2522id%2522%253A%2522cm0qexes200023b6jfy1cjcza%2522%252C%2522mode%2522%253A%2522permanent%2522%252C%2522type%2522%253A%2522FILE%2522%252C%2522initialSelections%2522%253A%255B%257B%2522startLineNumber%2522%253A2%252C%2522startColumn%2522%253A38%252C%2522endLineNumber%2522%253A2%252C%2522endColumn%2522%253A38%257D%255D%252C%2522filepath%2522%253A%2522%252Fsrc%252FApp.tsx%2522%252C%2522state%2522%253A%2522IDLE%2522%257D%255D%252C%2522id%2522%253A%2522cm0qesp6600023b6jcwmwtrui%2522%252C%2522activeTabId%2522%253A%2522cm0qexes200023b6jfy1cjcza%2522%257D%252C%2522cm0qesp6700063b6jay6yvsj1%2522%253A%257B%2522tabs%2522%253A%255B%257B%2522id%2522%253A%2522cm0qesp6700053b6jm5n2a22m%2522%252C%2522mode%2522%253A%2522permanent%2522%252C%2522type%2522%253A%2522TASK_PORT%2522%252C%2522taskId%2522%253A%2522dev%2522%252C%2522port%2522%253A5173%257D%255D%252C%2522id%2522%253A%2522cm0qesp6700063b6jay6yvsj1%2522%252C%2522activeTabId%2522%253A%2522cm0qesp6700053b6jm5n2a22m%2522%257D%252C%2522cm0qesp6700043b6j8bqtjdfo%2522%253A%257B%2522id%2522%253A%2522cm0qesp6700043b6j8bqtjdfo%2522%252C%2522tabs%2522%253A%255B%257B%2522id%2522%253A%2522cm0qesp6700033b6jcdlpy22d%2522%252C%2522mode%2522%253A%2522permanent%2522%252C%2522type%2522%253A%2522TASK_LOG%2522%252C%2522taskId%2522%253A%2522dev%2522%257D%255D%252C%2522activeTabId%2522%253A%2522cm0qesp6700033b6jcdlpy22d%2522%257D%257D%252C%2522showDevtools%2522%253Atrue%252C%2522showShells%2522%253Atrue%252C%2522showSidebar%2522%253Atrue%252C%2522sidebarPanelSize%2522%253A15%257D)
@karsa-mistmere Agreed. And overlapping it exactly with `eye` icon makes the icon not vertically centered right? In that case I think the 1px shift downwards is the best we can...
@karsa-mistmere Yes and no. I think "utensils" is also what it depicts. Not sure if I see this as "wrong" named. But utensils can be more than only a fork...
@karsa-mistmere Great idea!
I think I like the alternative better