add license?

[sidorares]

Hi @ericclemmons ! Your fork is mostly based on code from https://github.com/sidorares/hot-module-replacement which is MIT licensed. Would you mind adding license and copyright to your copy?

[ericclemmons]

Planning on removing this module. Was testing something out and it didn't work :-(

On Tue, Dec 4, 2018, 9:50 PM Andrey Sidorov <[email protected] wrote:

Hi @ericclemmons https://github.com/ericclemmons ! Your fork is mostly based on code from https://github.com/sidorares/hot-module-replacement which is MIT licensed. Would you mind adding license and copyright to your copy?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ericclemmons/hot-module/issues/3, or mute the thread https://github.com/notifications/unsubscribe-auth/AAA7TnyiuOM9SmHv2hc9MVZRI9vFcKvxks5u116RgaJpZM4ZCDTu .

[sidorares]

No problems. If you can share what didn't work that would be great

[ericclemmons]

Related to #1, I was at work trying to intro HMR without Webpack (basically patching require with chokidar and what not) when a few hours in a lucky google returned your project: https://github.com/sidorares/hot-module-replacement

Since I had the NPM link & all setup, I went ahead & copy/pasted your code over mine since it looked more robust.

Here's the lousy part: I can't make a smaller example of the bug in this repo.

I'll try it once more with your lib in ~2 weeks when things settle down & open an issue there to track it.

Going to archive this repo now, since it started thinking that no-one else solved it, found you're already doing it, then discovered our project has some edge-case.