quagga2 icon indicating copy to clipboard operation
quagga2 copied to clipboard

fix - remove use of node Buffer

Open yogeshgadge opened this issue 9 months ago • 3 comments

just removed Buffer from type definitions

yogeshgadge avatar May 01 '24 14:05 yogeshgadge

Change Log for @ericblade/quagga2 (1.8.4 → 1.9.0)

Refactors

  • Browser targeted Typescript apps can now use quagga2 without adding node types

Edit changelog

rollingversions[bot] avatar May 01 '24 14:05 rollingversions[bot]

i'd like to have a look at the node code that takes the buffer input, and make sure that it doesn't do anything weird, but good to know that this should fix the consumer side of it. I'm actually guessing that it probably works fine, just that this was all written long before Buffer was actually an extension of Uint8Array in node

ericblade avatar May 02 '24 20:05 ericblade

all tests successful, so it's pretty likely that there's no issue here, but i do want to take a look at the code in question before i merge

ericblade avatar May 02 '24 20:05 ericblade