quagga2 icon indicating copy to clipboard operation
quagga2 copied to clipboard

Consider removing Buffer from node code, replace with native array type

Open ericblade opened this issue 9 months ago • 3 comments

More info: https://sindresorhus.com/blog/goodbye-nodejs-buffer

Also would provide a better fix for: https://github.com/ericblade/quagga2/issues/509

The current fix is just to install the type, because it doesn't matter... but it could matter in user code.

ericblade avatar Apr 30 '24 23:04 ericblade

added PR https://github.com/ericblade/quagga2/pull/539

yogeshgadge avatar May 01 '24 14:05 yogeshgadge

side observations: root tsconfig.json has types ["mocha", "node"] probably consider tsconfig.test.json for the mocha tests inside src/

yogeshgadge avatar May 01 '24 14:05 yogeshgadge

good idea. there's been some recent upgrades to typescript's handling of nested tsconfig files, too, an update to current ts is probably a good idea too

ericblade avatar May 02 '24 20:05 ericblade