Results 656 comments of Eric Blade

@copilot can you rebase now, and reasses? significant reorganization has been done in testing, and i honestly do not remember if i've made any progress towards this specific goal or...

@copilot since the time this was last touched, we've completely reimplemented the change that necessitated this, and added a WHOLE lot more testing. Is the bug that this was needed...

@copilot I see that one of the documentation notes you removed said "Should migrate to `core-js@3` + `regenerator-runtime`" ... is that advice still valid? like, do we even need core-js...

@copilot yeah, try removing that, and let's see what happens does "last 2 versions" make sense? does that get us like 95% or more of users? or should we be...

Certainly something to add to the test suite to play with. Yes, it can and should work, but it probably would require some fiddling with the settings to find the...

Well, it doesn't work with any setting in the sample application ( https://ericblade.github.io/quagga2/examples/file_input.html ) as far as I can tell. It may take some analysis to figure out if that's...

@copilot well, I did first ask you to *analyze*, not to implement, because you often go ahead and implement something and it's the wrong thing, and then we end up...

@copilot is there a compelling reason to not use ndarray in the browser version? I feel like the original author may have had a reason to not use it, but...

@copilot i think you misunderstand here. I need for the grab() functions from each to be tested. Not something that is vaguely similar to them, but as close to the...

@copilot is there some reason you didn't complete? you can import the browser and node versions directly into either the browser or the node tests, so long as they don't...