ericLemanissier
ericLemanissier
The build is now finished. You can take a look at the results [here](https://github.com/ericLemanissier/proof-of-conan/actions/runs/8799846282/attempts/2)
it's blocked by https://github.com/conan-io/conan-center-index/pull/23515 anyway, there is a conflict on expat with fontconfig since https://github.com/conan-io/conan-center-index/commit/56ca59263f11ea8b096a4e5a893ddf99d697adf4
@uilianries @RubenRBS this is ready for review and merge
The build is now finished. You can take a look at the results [here](https://github.com/ericLemanissier/proof-of-conan/actions/runs/8702528022/attempts/9)
@uilianries @RubenRBS this is ready for review and merge
@RubenRBS do you think it's ok ?
@jcar87 are you OK with this PR? Do you want the default value of `essential_modules` to be fixed to False?
Once again, pylint is very useful to catch bugs. please consider https://github.com/conan-io/conan-center-index/pull/23758 which should drop conan1 support for the linter
any typo in variable/attribute/function name in a non-taken branch can only caught by a static analyzer. not very recent, but still: https://github.com/conan-io/conan-center-index/pull/7749#issuecomment-982468172 https://github.com/conan-io/conan-center-index/pull/11238 https://github.com/conan-io/conan-center-index/pull/11239 https://github.com/conan-io/conan-center-index/pull/11213 https://github.com/conan-io/conan-center-index/pull/22158/commits/983176e1c4d6a40bd130a32e851505fb2cc3af87
Maybe you did not see the edits to my message ?