Eric Wieser

Results 482 comments of Eric Wieser

That looks like an unrelated problem to do with projecting mouse movements to me. It's also 10 years old - is that bug still present?

Note that the original reproduction I gave has been fixed by correcting the definition of pi in leocad to be the most faithful 32-bit float definition. The issue almost certainly...

> and then at some stage mutated > > If I am missing something please explain what I am missing in how mypy makes this safe. Mypy will detect any...

From an early conversation I forgot about: > The function foo_bad will do as you ask and reverse the list. What am I missing here? In the original function I...

> So what benefit does setting the default dictionary add? If you just omit that, the runtime will also make sure you're always passing a Mapping object every time this...

@ThiefMaster, if you requested that change when reviewing the code in https://github.com/PyCQA/flake8-bugbear/issues/137#issuecomment-805924849, you would be introducing a bug

It might make sense to handle #14583 first, so that we can avoid having extra scalar rings here.

You probably need an `include \sigma` line to make lean aware that you intend to refer to `\sigma`

I think the ball was in @YaelDillies' court (https://github.com/leanprover-community/mathlib/pull/12746#discussion_r846250593), but perhaps we shouldn't be waiting since we have two maintainer votes for `old_structure_cmd` and plenty of time for Yaël to...

I'm afraid I'm too time-constrained to refresh myself on the full context here. I don't think I have any major concerns here, so I'm happy to delegate to another maintainer...