Eric Burel

Results 244 comments of Eric Burel

I think the default_resolvers basically does the same as the new, except they are also accepting the old API. This PR does not remove the "old" resolvers hopefully but only...

Just tried and yeah, it doesn't solve my build issues sadly

If that's just a matter of waiting Apollo to update you can probably quickfix in your codebase and let them fix it. Is there an action required from Vulcan in...

Ok makes sense, I'll check that. In the meantime you can implement the "data/previousData" stuff locally with `useState`. I'll do a big pass on all tickets when the NPM version...

Yeah makes sense indeed. I would be happy to merge the proposed change asap, it sounds relevant to me.

`results` is a Vulcan specific shortcut (btw in NPM version I renamed it `documents` for consistency with mutations) so we are free to implement whatever default behaviour we want, no...

Related to: https://stackoverflow.com/questions/42862028/react-router-v4-with-multiple-layouts Not sure yet how to handle this. Maybe identifying automatically registered routes that got the same layout, and creating a group of routes for each layout (as...

Also can this state be moved in an `App` wrapper instead? Or maybe you need to switch it/reset it on certain route changes?

It seems that this comment could help us to avoid remounting when components share the same layout: https://stackoverflow.com/a/57358789 I haven't tested much but it seems to be functional. For us...

Fun fact: I was going to paste the same article, almost a year later. Yeah it's completely relevant and technically that's what we should do in Vulcan. So my PR...