circomkit icon indicating copy to clipboard operation
circomkit copied to clipboard

chore: Remove special fix for plonk verifiers

Open numtel opened this issue 1 year ago • 2 comments

https://github.com/iden3/snarkjs/pull/464 was merged and is now included in snarkjs 0.7.5 so we can remove the special case for plonk verifiers:

https://github.com/erhant/circomkit/blob/main/tests/circomkit.test.ts#L97

The way snarkjs is set as a peerDependency for 0.7.x, it would need to be updated to ^0.7.5 too I would imagine though

numtel avatar Oct 18 '24 21:10 numtel

good point!

The way snarkjs is set as a peerDependency for 0.7.x, it would need to be updated to ^0.7.5 too I would imagine though indeed

will include this for some minor version update soon, but lets wait a bit until SnarkJS gets updated around the place 👍🏻

erhant avatar Oct 25 '24 18:10 erhant

the existing fix does not break with the fixed snarksj version though right?

erhant avatar Oct 25 '24 18:10 erhant