ergo icon indicating copy to clipboard operation
ergo copied to clipboard

`GetPeers` suggestions

Open ross-weir opened this issue 2 years ago • 2 comments

Couple of suggestions for GetPeersSpec messages to help with light node client efficiency, maybe premature optimizations but wanted to make note:

  1. Include a count parameter so the requester can limit how many peers are received, for example a light client might only want to request 10 peers to reduce network usage. If a node sends back more peers than requested and is running on a recent version maybe consider it a malicious peer or just process them.
  2. Include a filter (bloom filter maybe) parameter to increase the chance of receiving peers a node doesn't already know about for increased efficiency and reduction in redundant data

ross-weir avatar Feb 22 '23 23:02 ross-weir

Peer entries are just a couple of bytes, is there really any reason to limit how many are received?

satsen avatar Nov 02 '23 18:11 satsen

Peer entries are just a couple of bytes, is there really any reason to limit how many are received?

Mode feature in peer specs are allowed to be up to 512 bytes alone

I still think it would be nice to have for light clients in particular

ross-weir avatar Nov 02 '23 23:11 ross-weir