adept icon indicating copy to clipboard operation
adept copied to clipboard

chore: added pyproject.toml

Open jpbrodrick89 opened this issue 8 months ago • 7 comments

I'm only just trying to understand these now, so not sure how to check this is correct. Feel free to edit/suggest changes.

My main aim here is to iteratively build repo foundations (both adept and lagradept) to make dev work smoother in particular linting with mandatory pre-commit hooks. I am doing this step by step to make review process simpler.

jpbrodrick89 avatar May 01 '25 01:05 jpbrodrick89

The only thing I'm not sure about is how to enforce that cpu/gpu is selected, it might be better to have jax in core dependencies and have the cpu requirements empty.

Also should we add validate-pyproject into CI?

jpbrodrick89 avatar May 06 '25 23:05 jpbrodrick89

The only thing I'm not sure about is how to enforce that cpu/gpu is selected, it might be better to have jax in core dependencies and have the cpu requirements empty.

I think the correct version is chosen if you do pip install adept[cpu] vs pip install .[gpu]. Does that answer your question? Either way, feel free to do what you think is best. There is no purpose for this file right now besides whatever it is you need it for!

Also should we add validate-pyproject into CI?

I have no idea what this is! Your call

joglekara avatar May 07 '25 16:05 joglekara

What I mean is should it throw an error when we run install pip install adept or should this just default to be the equivalent to pip install adept[cpu]. I think I'll go with the latter which is what Jax does.

jpbrodrick89 avatar May 07 '25 19:05 jpbrodrick89

yes that sounds reasonable

joglekara avatar May 07 '25 19:05 joglekara

All good, feel free to hit squash and merge 🙂

jpbrodrick89 avatar May 16 '25 19:05 jpbrodrick89

Actually, need to update the file to match your new requirements will see if I have time tonight but feel free to do it on your side if you like.

jpbrodrick89 avatar May 16 '25 19:05 jpbrodrick89

Done, if we set up uv in the future, syncing all our various requirements files with pre-commit hooks becomes a lot simpler/actually possible!

jpbrodrick89 avatar May 16 '25 21:05 jpbrodrick89