Erfan Safari comments

Results 111 comments of


                                            Erfan Safari

Custom string validator function adds unwanted key to parent object

repro commenting out custom checker function will change the final result ```js const v = new Validator({ // debug: true, useNewCustomCheckerFunction: true, defaults: { object: { strict: true, }, string:...

Custom string validator function adds unwanted key to parent object

@icebob I think we should never call custom checker function when value is null or undefined related to #189

Custom string validator function adds unwanted key to parent object

@icebob Nah, Run my repro code to better understand it

Custom string validator function adds unwanted key to parent object

> Can we move this highlighted parts into the "else" branch? I'm okay with this solution. (In fact, my solution was the same, but in another words)

CI workflow should check code format

I suggest [dprint](https://github.com/dprint/dprint) Used by Deno built-in formatter

Show warning on bad schema

@icebob Yes, `strict` option is good

swc: Support paths from tsconfig

@spmiller I came across this today. but here's a thing. we should not add a feature that is only available on swc. I think this feature is not supported by...

swc: Support paths from tsconfig

@spmiller I have made a tiny repo for you: https://github.com/erfanium/esm-ts-paths in tsconfig file, either using `swc: true` to `swc: false` doesn't make it work. that means this feature is not...

Sequelize errors don't print properly in jest

I believe this change can fix this issue. Change this: https://github.com/sequelize/sequelize/blob/19ca248bef67067b9c746ee348a82fc267c206db/src/dialects/postgres/query.js#L60 To something like this: ```js throw this.formatError(error, isJest ? error.stack : errForStack.stack); ``` for all dialects

Implement `db.collection.bulkWrite()`

@Plawn try import from npm:mongodb