Erez Rokah
Erez Rokah
Maybe we can do a feature request for https://github.com/netlify/delta-action? Seems like it would be useful for every consumer of that action
We would first need to make the benchmarks more consistent see https://github.com/cloudquery/plugin-sdk/pull/1572#issuecomment-2010197228, I updated the title of the PR accordingly
OK so apparently only the recent writers benchmarks are noisy we'll silence those (renamed the PR title back)
Closing as stale/wontfix. I think https://github.com/netlify/delta-action already does this for us, but if not we can re-open this issue. Regardless we might to re-think how we want to measure SDK...
> @erezrokah This make sense, can you add the test for it? Thank you Sure 💯 Added in https://github.com/okta/okta-sdk-golang/pull/450/commits/0cf4f9a41bb17391a928c9220cde8b7153c18c85
> Hi @erezrokah, I believe your test is not correctly formed. Thanks for the detailed response @rickb-monad ❤️ I'll take a look this week and update the PR
Not stale, will try to address the comments this week
Not stale, sorry for not being able to follow up on this yet