Erez Rokah

Results 453 comments of Erez Rokah

Thanks @ascorbic, to add to it, we'll probably want to re-run `build` on changes to source files.

Hi @dsifford, can you share which package manager are you using to upgrade? Is it `npm` or `yarn`? If `npm` can you trying using the latest version by running `npm...

Ah, that's very useful. Can you provide the structure of your monorepo and where the CLI is referenced?

Hi @dsifford, sorry I missed your last comment and also haven't had the chance to look at this. Until we can get to the bottom of this issue, a possible...

Ice boxing this for now, we had quite a few tests hitting the real API in the CLI repo. We eventually switched to mocking the API calls, due to stability...

I don't think we need to migrate all tests, just the ones where it makes sense. I do find it harder to know what the test is asserting with snapshots...

> We could experiment with it, what do you think? Sure that would work. You were thinking about adding an argument to `runFixture`? Something like that?

Use case is writing a detailed error message to the logs (for the lighthouse plugin - specific audits that failed), while a short error message to the UI summary (for...

https://github.com/netlify/build/issues/763 can help make the APIs more clear

I think this makes perfect sense as we'll be replacing the current IPC mechanism with the one we're planning to use long term.