taiga icon indicating copy to clipboard operation
taiga copied to clipboard

Anime cover image at sidebar

Open koteq opened this issue 8 years ago • 16 comments

It would be great to have a selected anime cover image displayed at sidebar above "Now Playing". I don't really know is it hard to implement or not but I think the idea is good. As for me I often open "Anime Information" window just to see that image because I don't clearly remember all anime by titles.

Also it may work as shortcut to open anime web page.

Mock

koteq avatar Mar 02 '16 22:03 koteq

I'm not fond of this idea primarily because it breaks the logical structure of the UI (i.e. selecting an item inside Anime List page causes an image to be displayed outside of it). There are also other concerns such as the variable height of poster images, sidebar items moving up and down if the image is placed at the top, and so on.

I think that adding grid-view mode to Anime List (#87) is a much better idea overall, which satisfies the same use case. (Edit: I should also mention that I'm not planning any major UI changes until v2.0)

erengy avatar Mar 03 '16 01:03 erengy

Agreed, this view mode is just awkward, but exploring additional UI designs is important. I think UI overhaul is listed as a long term goal.

VivaLaPanda avatar Mar 03 '16 01:03 VivaLaPanda

In my opinion it does not breaks anything. Its like a preview pane it can't be inside of the list view. It could have static size to fight variable posters heights. It could hold it's place even if no applicable item are selected to prevent sidebar items jumpy behaviour or it could be moved to the bottom of the sidebar.

As for grid-view. The idea is different somehow. The grid-view will occupy large amount of space. I personally prefer to use details list view because it's compact, contain more information and allows me to quickly sort items.

There are some examples how this kind of functionary implemented in different apps: Windows Explorer and Dialog Boxes, TotalCommander, FastStone Image Viewer.

koteq avatar Mar 03 '16 11:03 koteq

how about put it below the torrent feed icon. there is so much space on the left side bar and im so bad at names without pictures. can you pls add pic preview so i dont need to double klick for more info to see the cover pic of the anime?

amboris avatar Apr 13 '16 10:04 amboris

I was able to implement the feature without any C++ knowledge and seeing VS2015 first time in my life. I just thought it's could be easily implemented and it was so. Screenshot

~I don't think that you interested in my shitty implementation so I won't share any. I'll be still waiting to see it in the v2.0. Thanks for great app.~

koteq avatar Apr 17 '16 10:04 koteq

oh come on man don't be so mad. its a one man project and @erengy just dont have much time to work on it. even if he does there a so many feature requests to go through. the reason why most people put up their project on github is that other can help the project growing.

btw this is what i need!

pls just go to code and make a pull request so he can implement. and all of us can be happy ;) if you got the drive you could even go check out the other request and implement it through pull request and we will reach v2.... way faster than with one developer.

amboris avatar Apr 17 '16 14:04 amboris

@amboris I won't be able to make the feature to work consistently in each section of the app nor write clean code which may be acceptable by project owner.

Now I think it was a bad idea to write about what I did, but I was really happy at the moment so couldn't resist. Sorry if I insulted someone, software development is a serious business.

koteq avatar Apr 17 '16 22:04 koteq

Maybe I'm the one who misread the comment in question, but it didn't seem offensive to me. In fact, if you were able to do it without any prior C++ experience, then it means that the codebase isn't actually as bad as I think it is!

While it's true that the feature is quite easy to implement, I cannot accept a pull request on this as I still have my doubts about the image placement. Still, I wouldn't want to discourage anyone from contributing to Taiga or other open-source projects.

Shoving an image at the bottom of the sidebar may not be the correct way of doing it, but it's obvious that a preview pane could be useful for some users (thanks for the example images, by the way). I'll keep this issue open for future consideration.

erengy avatar Apr 18 '16 05:04 erengy

I think it's better to have a preview panel instead.

This is an example design I made (A Taiga-like application design prototype - not necessarily a design proposal for Taiga itself) image

akippnn avatar Apr 03 '23 23:04 akippnn

Rebasing my somewhat working solution on top of the current master branch, see https://github.com/koteq/taiga. It comes with a binary release, or GitHub Actions workflow for those who would like to build the binary themselves 🏗️

koteq avatar Apr 08 '23 23:04 koteq

@koteq thanks works great!

PS: for all who dont know how to use the mod. go to your existing taiga folder and replace the existing taiga.exe with the mod (taiga.exe) you download from koteq.

amboris avatar Apr 09 '23 19:04 amboris

@koteq Nice work! just on question, do you know why preview image randomly flickers when navigation the sidebar ui?

SacredZenpie avatar Jun 13 '23 18:06 SacredZenpie

the exe gives TrojanDropper:Win32/Wacatac.B!ml on Windows defender

hecode avatar Jul 18 '23 18:07 hecode

Both modded and original binaries are considered as having viruses by some security vendors, here are the scan details:

kgoryunov avatar Jul 18 '23 20:07 kgoryunov

Are you sure its windows defender detecting it? Ive never had it false positive detect taiga before, but some antiviruses I did.

SacredZenpie avatar Jul 18 '23 20:07 SacredZenpie

it was Windows Defender ya, win11, latest. it only happened with the modified exe today though. I had been using it with no warnings from Windows Defender for a month at least. and it didn't trigger anything from the original.

hecode avatar Jul 18 '23 21:07 hecode