taiga icon indicating copy to clipboard operation
taiga copied to clipboard

Path is longer than MAX_PATH

Open darkred3 opened this issue 2 years ago • 1 comments

Cannot open a file whose path is apparently too long. 2022-12-30 18:17:07 [Warning] file.cpp:139 ShellExecuteW | Path is longer than MAX_PATH: C:\Users\XXXXXXX\Desktop\Torrent Downloads\Scissor.Seven.S01-03.1080p.NF.WEB-DL.DDP2.0.x264-GST [Multi-Dub][Multi-Subs]\Scissor.Seven.S01.1080p.NF.WEB-DL.DDP2.0.x264-GST\Scissor.Seven.S01E05.Assassinating.a.Domineering.Grannie.1080p.NF.WEB-DL.DDP2.0.x264-GST.mkv

Should this not have been fixed with the 2022-11-02 update?

darkred3 avatar Dec 31 '22 16:12 darkred3

Relevant commit: a5505240aa95944508c9410a73e053bfb81e99b6

According to Microsoft's documentation:

  • You must be using Windows 10 version 1607 or above.
  • Taiga being long-path aware is not enough, you must opt-in to the new behavior by setting a registry key.
  • ShellExecuteW and ShellExecuteExW are not included in the list of functions that no longer have MAX_PATH restriction.

I can confirm that Taiga is unable to open that file path, even though my system meets the conditions above. It seems as if the function succeeds, since ShellExecuteEx returns TRUE and GetLastError returns ERROR_SUCCESS. So I'm not sure what's going wrong there.

erengy avatar Jan 01 '23 15:01 erengy