Benoit Daloze

Ripper is slow on TruffleRuby

2

The cause is pretty clear, here it's from running the `ruby-lsp` benchmark (with `gem "syntax_tree", "4.0.2"`): ``` ruby --engine.TraceCompilation -Iharness benchmarks/ruby-lsp/benchmark.rb |& grep 'opt fail' [engine] opt failed id=72976 Lexer#advance...

Following the logic of https://github.com/ruby/readline/blob/master/lib/readline.rb We have that file at https://github.com/oracle/truffleruby/blob/master/lib/mri/readline.rb But we also have https://github.com/oracle/truffleruby/blob/master/lib/truffle/readline.rb and that's earlier in `$LOAD_PATH`. So we should try to just remove the JLine...

Pass the hexapdf test suite

5

This used to work in https://github.com/oracle/truffleruby/issues/1391. Unfortunately there was no CI for hexapdf at the time and it regressed (e.g. #2770). Now hexapdf has a CI: https://github.com/gettalong/hexapdf/pull/199#issuecomment-1375494255 So we should...

The test suite fails like so (note: it's actually a lot faster to run the test suite on `jvm-ce` than `jvm`): ``` $ chruby truffleruby-jvm-ce $ bundle exec rake test...

Maybe it changed in CRuby, in any case latest CRuby includes them. In TruffleRuby it doesn't include them since b3bfc9d388331bfbdf5ea3f238317ecc316ed7a7. We still need to hide singleton classes which don't have...

Re-enable the truffleruby test on macOS

1

It was disabled in https://github.com/rvm/rvm/pull/5119 and means this bug was not caught: https://github.com/rvm/rvm/pull/5385

Add test for using setup-ruby twice in the same workflow

1

Extracted from https://github.com/ruby/setup-ruby/issues/444#issuecomment-1377723414

Write specs for new Ruby 3.2 features and changes

13

ruby/spec already contains some specs for 3.2, but we should aim to cover all new features and important changes. This will improve the test coverage of these features (and maybe...

Cleanup proc_spec.rb and block_spec.rb

1

Currently it's a mess with lambda in proc_spec.rb. Proposed organization: * block_spec.rb: only passing a block to something else * lambda_spec.rb: as it is, lambda semantics * proc_spec.rb: remove `lambda`...

rb_wait_for_single_fd() should probably be used instead of rb_thread_fd_select()

1

I've noticed this gem is using rb_thread_fd_select() in https://github.com/redis/hiredis-rb/blob/d62cb77c72fe292e4f35f385467006096b7d9e3b/ext/hiredis_ext/connection.c#L94 And it's used by https://github.com/redis/hiredis-rb/blob/d62cb77c72fe292e4f35f385467006096b7d9e3b/ext/hiredis_ext/connection.c#L126 and https://github.com/redis/hiredis-rb/blob/d62cb77c72fe292e4f35f385467006096b7d9e3b/ext/hiredis_ext/connection.c#L156 to wait for a single file descriptor, either read or write. rb_thread_fd_select() uses select(2)...