Benoit Daloze

Results 1300 comments of Benoit Daloze

This is done. There will be more optimizations following, but the core work is done for 24.0.

One longer-term solution is using the new Ruby parser YARP, which should be able to emulate Ripper and that parser would run natively not on Sulong.

With #3118 Ripper is now executed natively and so Ripper (and notably `ripper_yyparse`) is compiled by gcc/clang. It's about 10 times faster: ``` $ ruby -rbenchmark -rripper -e 'c=File.binread("src/main/ruby/truffleruby/core/io.rb"); 10.times...

Yes, that's fine, there is no urgency for this issue/PR. If you need any help feel free to ask @nirvdrum or on the GraalVM Slack truffleruby channel.

Good point, I think CRuby never uses `(unknown)` or similar, so let's return `nil` in that case. @wasabigeek Could you do that?

Have you tried installing the gem? That works fine for me on Linux: ``` $ ruby -v truffleruby 24.0.0-dev-5a199d82, like ruby 3.2.2, GraalVM CE Native [x86_64-linux] $ gem i rice...

According to https://github.com/jasonroelofs/rice/blob/master/.github/workflows/testing.yml, one needs: ``` bundle exec rake headers bundle exec rake build bundle exec rake test ``` (that's rather unusual, but anyway) Using `truffleruby 24.0.0-dev-5a199d82, like ruby 3.2.2,...

If I comment out that line in `test_Builtin_Object.cpp`, then `bundle exec rake build` continues and indeed the linker fails with a lot of output like: ``` /home/eregon/code/rice/include/rice/rice.hpp:4220:47: warning: function may...

FWIW it seems CRuby still uses `-Wl,-undefined,dynamic_lookup`: https://github.com/eregon/actions-shell/actions/runs/7045968254/job/19176775307#step:4:60 ``` "DLDFLAGS"=> "-L/Users/runner/hostedtoolcache/Ruby/3.2.2/x64/lib -L/usr/local/opt/gmp/lib -Wl,-multiply_defined,suppress -Wl,-undefined,dynamic_lookup", ``` And from https://github.com/ruby/ruby/pull/6193/files it seems the `EXTDLDFLAGS='$(LIBRUBYARG_SHARED)'` case, i.e. no `-bundle_loader` flag: `"EXTDLDFLAGS"=>"-lruby.3.2",` We could...

From https://github.com/ruby/zlib/pull/75#issuecomment-1893944802, `MACOSX_DEPLOYMENT_TARGET=11.0` seems the easiest workaround for the cases of using XCode/Command line tools 14.2. But unfortunately [checking the version of Command line tools](https://apple.stackexchange.com/questions/180957/determine-xcode-command-line-tools-version/181994#181994) is quite slow: 70ms to...