Benoit Daloze comments

Results 1300 comments of


                                            Benoit Daloze

Data read with Zlib::GzipReader (but not copy of same data) slow to parse with JSON.parse

It's simpler than that, actually: ```ruby p Truffle::CExt.native_string?(previously_gzipped_data) # => true forced_copy = previously_gzipped_data + " " p Truffle::CExt.native_string?(forced_copy) # => false json = JSON.parse(previously_gzipped_data) p Truffle::CExt.native_string?(previously_gzipped_data) # => true...

Data read with Zlib::GzipReader (but not copy of same data) slow to parse with JSON.parse

Most likely involved, this `force_encoding` in JSON: https://github.com/oracle/truffleruby/blob/e020c89a8368ef2e1b996904f7becf65b375a47e/lib/json/lib/json/pure/parser.rb#L140 `previously_gzipped_data.encoding` is UTF-8 (maybe a bit surprising? But MRI behaves the same). And `force_encoding` actually returns a NativeRope when the source is...

Data read with Zlib::GzipReader (but not copy of same data) slow to parse with JSON.parse

Right, that's expected for TruffleRuby 20.3.0, thanks for confirming.

Fun with Dir.glob and filesystems

`File.fnmatch?` docs have a description of something probably related: ``` File.fnmatch('cat', 'CAT') #=> false # case sensitive File.fnmatch('cat', 'CAT', File::FNM_CASEFOLD) #=> true # case insensitive File.fnmatch('cat', 'CAT', File::FNM_SYSCASE) #=> true...

Fun with Dir.glob and filesystems

This seems really complicated and needing lots of low-level hacks, so I think we should wait until there is an actual need before trying to implement this.

Segfault on bundle install

Thanks for the report, I've filed an internal issue (GR-38555) for the native image team. It seems similar to #2646.

The grpc gem does not work yet at runtime (it installs fine)

It's `GR-23843` internally.

The grpc gem does not work yet at runtime (it installs fine)

@jeshan Please create a separate issue at https://github.com/oracle/graal, I'd like to focus this one on getting grpc to load on TruffleRuby. I digged into this some time ago with @norswap....

The grpc gem does not work yet at runtime (it installs fine)

With that fix, this happens: ``` $ ruby greeter_server.rb |& c++filt /home/eregon/code/truffleruby-ws/truffleruby/mxbuild/truffleruby-jvm/jre/languages/ruby/lib/gems/gems/grpc-1.34.0.dev/src/core/lib/iomgr/exec_ctx.h:223:in `grpc_iomgr_init': \ External LLVMFunction TLS init function for grpc_core::ExecCtx::exec_ctx_ cannot be found. (com.oracle.truffle.llvm.runtime.except.LLVMLinkerException) (RuntimeError) Translated to internal error...

The grpc gem does not work yet at runtime (it installs fine)

> TruffleRuby doesn't have a case for the LLVMSignedCastToI64VectorNodeGen node with values of type com.oracle.truffle.llvm.runtime.vector.LLVMPointerVector (TypeError) > I have a fix for that one, I'll try to merge it to...