Benoit Daloze

Results 1302 comments of Benoit Daloze

Go ahead :)

`exit code 137` typically means out of memory. We should investigate what takes so much memory.

GitHub runners have 8GB of RAM IIRC, so `--vm.Xmx16G --vm.Xmn4G` doesn't seem good there, the default memory settings should be adapted to the actual RAM available. We should reproduce locally...

Thanks for the report. This seems interesting to look at, given the large difference in time. I'm not sure the printed time is actually time spent to run this test...

@aardvark179 is working on flamegraph output for CPUSampler, that should make it easier to analyse profiler output. I typically use the default histogram or the flamegraph, I find the calltree...

> Additionally, we can polymorphic inline cache the method lookup based on the types of arguments passed to the callee. I think method lookup should remain independent of arguments. But...

Note that because of Ruby semantics, if we see `foo(a: 1, b: 2)` it doesn't mean `foo` accepts keyword arguments, it could be `def foo(h)` or def `foo(**h)` or `def...

I think the approach I suggest is quite similar to the paper (but a lot of details were different back then, most notably the dispatch chain was done manually without...

> 99% of dynamic calls with keyword arguments do not have any kind of splatting I wouldn't be sure, `**kwrest` is fairly frequent for delegation. And in that case, for...