Benoit Daloze

Results 1302 comments of Benoit Daloze

Actually we should probably also allow libv8-node as a binary gem, because there is no point to compile it and it has a high chance to fail (same on CRuby...

For some reason RubyGems/Bundler think `x86_64-linux-musl` is appropriate but that's not and fails later: ``` Fetching libv8-node 16.10.0.0 (x86_64-linux-musl) Installing libv8-node 16.10.0.0 (x86_64-linux-musl) Fetching mini_racer 0.6.2 Installing mini_racer 0.6.2 with...

It all works fine now: https://github.com/oracle/truffleruby/issues/1827#issuecomment-1216789791 musl being used is a RubyGems/Bundler bug: https://github.com/rubygems/rubygems/issues/5508, but it shouldn't matter as we don't use libv8/libv8-node anyway for the MiniRacer bakend.

``` lib/mri/bundler/dep_proxy.rb:45:in `method_missing' - undefined method `to_ary' for :Gem::Dependency ``` is present on both TruffleRuby and MRI, so it probably comes from Bundler code. It would be useful to investigate...

I'm glad I asked, it seems these ENOENT happen on MRI 2.6.5 too. Which sounds like FileUtils or zlib is quite a bit better for exceptions in MRI 2.7+. The...

https://github.com/oracle/truffleruby/commit/b6c91eccb46a0b03f9f4cf04f6fb5fbbbb591ae6 goes in this direction and always inlines generated accessors, Module#attr_* themselves, visibility methods (private/protected/public) and #using. That probably does not affect stack depth much as they are all leaf...

I'm making progress on this, removing the `CatchFor*Node` and `ExceptionTranslatingNode` for method/lambda/proc and moving that logic inline in subclasses of RubyRootNode: 4e900526025b8116600329be2b9f1a2503ae90dc For lambdas we have a slightly unfortunate arrangement...

There were 2 PRs here: 4e90052 and 4abc6b6e68a62a4956f7bd58a52b57741cf7b254 (complete diff: 14322c1778b03279ea1b4efb71bb1dfa8a8d0e53...4abc6b6e68a62a4956f7bd58a52b57741cf7b254) So it would be interesting to compare before them at 14322c1778b03279ea1b4efb71bb1dfa8a8d0e53 and after them at 4abc6b6e68a62a4956f7bd58a52b57741cf7b254. Those PRs should...

I'll reopen because only part of the ideas here were done.

We noticed 20-25% improvements on the deltablue and richards in interpreter-only mode (Native CE & EE, `--engine.Compilation=false`) for 2e3bf7d50321a5ffc48906829e7bb1e2a4bece53...5474e163faf1aff6cea1935450b198536e2d8b19. That's quite a few commits, but it notably includes b1e4506 and...