Benoit Daloze

Results 1293 comments of Benoit Daloze

@ko1 Could you review this? The `rbconfig/sizeof` extension defines two frozen Hashes, so it should be fine to access it from multiple Ractors. Do they need to be made `Ractor.make_shareable`...

It looks OK except the first 3 lines in the heredoc are unnecessary (the requires and include). See https://github.com/search?q=repo%3Aruby%2Fruby%20assert_separately&type=code for examples

Right, I guess rb_ext_ractor_safe() only affects methods defined in native extensions and not modules/classes/constants? Would it be OK to still mark the extension (by adding the `rb_ext_ractor_safe(true)` as in this...

I think we should add this test or similar because e.g. it wouldn't work with Ractor if the Hash were not shareable/deeply-frozen. There is no need to mark the extension...

Thank you for the report. This is because https://github.com/oracle/truffleruby/blob/5aa58980aefa26688671dc1aa58752907b81f475/src/main/java/org/truffleruby/parser/YARPPatternMatchingTranslator.java#L313 uses the original `Hash#[]` definition and does not do a dynamic call to `[]`/`key?`. It's a lot more efficient to not...

It would be great to move this repo to ruby/json, specifically so it is possible to add new maintainers without asking @flori every time (since it has proven difficult to...

From a quick look at https://github.com/SamSaffron/fast_blank/blob/d1695581e397b0b00fb589edae0dec99ce846e42/benchmark#L8-L14 it would probably be mostly dominated by Regexp. BTW these should probably use `.match?` and not `===`, it's old code. The current `blank?` in...

Ah so this prolog causes `which` in Windows Bash to think it's not a proper executable? (maybe it no longer starts with a shebang?) I think that's something worth reporting...

Still happening for mingw, mswin and ucrt e.g. on https://github.com/ruby/setup-ruby/pull/665 I will remove that check in CI until this is solved so the CI is not permanently red.