cose-js icon indicating copy to clipboard operation
cose-js copied to clipboard

Introduce synchronous sign?

Open oyooyo opened this issue 2 years ago • 2 comments

I would like to also have a synchronous createSync() version of sign.create()

In #47, @JesusMcCloud already suggested synchronous createSync() and verifySync() functions, but apparently only verifySync() was actually introduced.

Is there a good reason for that, or was createSync() simply forgotten?

oyooyo avatar Aug 18 '22 06:08 oyooyo

Odd… the original MR has the export added. see: https://github.com/erdtman/cose-js/pull/47/commits/e75fea351d059866c887952ec7efacb2ae4c74a0#diff-02346278010f5099e4be2cae18e3a443e44892be47996d75abf55602e0349b8bR62

JesusMcCloud avatar Aug 18 '22 12:08 JesusMcCloud

It was a long time ago, but I think I ran into problems with large payloads and the sync cbor functions.

erdtman avatar Sep 14 '23 21:09 erdtman