Eric Donovan

Results 13 issues of Eric Donovan

most of the test files don't actually mock anything but still feature the line: ```MockKAnnotations.init(this, relaxed = true)``` - remove unused mockk references from ```NavigationExtensionsTest```, ```NavigationModelLinearNavTest``` & ```NavigationModelNestedNavTest```

quickfix
code

1) This already works for linear navigation graphs (see ```NavigationModelLinearNavTest``` and the tests that refer to ```setData```), but we need to verify the behaviour for nested navigation graphs, there are...

code

N8 needs a logo! if no-one volunteers one, it's going to be a crap one drawn by me

other

The serialization code can be taken from https://github.com/erdo/persista the key lines we'd need are: ``` val jsonText = json.encodeToString(serializer(stateKType), item) ``` ``` json.decodeFromString(serializer(stateKType), jsonText) as NavigationState ```

code

Code samples / comments are messed up in TabHost navigation section https://github.com/erdo/n8?tab=readme-ov-file#tabhost-navigation the code comment part has not been terminated properly

quickfix

There are a few button labels in the sample app that say "...(or exit)". If the user is automatically navigated back beyond the end of the navigation graph, the user...

quickfix

the section https://github.com/erdo/n8?tab=readme-ov-file#some-ideas-for-what-to-do-next needs a little tidy, some items can be removed: - finish a simple example app - setup circle CI to run unit tests those have both been...

quickfix

Predictive back is working for iOS NavigationStack / N8 integration. Look into the android equivalent. n8.peekback() will provide us the state needed to render the expected back destination on the...