webdriver-binaries-gradle-plugin icon indicating copy to clipboard operation
webdriver-binaries-gradle-plugin copied to clipboard

add gradle 8.7 compatibility via org.ysb33r.gradle:grolifant-herd:4.0.0

Open jamesfredley opened this issue 1 year ago • 4 comments

will resolve:

  • https://github.com/erdi/webdriver-binaries-gradle-plugin/issues/43
  • https://github.com/grails/grails-testing-support/issues/443

replaces:

  • https://github.com/jamesfredley/webdriver-binaries-gradle-plugin/pull/1

Changes were made to enable tests to run on Windows 11.

Fully tested against:

  • https://github.com/grails/grails-functional-tests
  • https://github.com/grails/grails-testing-support - also requires org.asciidoctor:asciidoctor-gradle-jvm from 4.0.1 to 4.0.3

jamesfredley avatar Oct 22 '24 20:10 jamesfredley

@erdi @jonnybot0

jamesfredley avatar Oct 25 '24 17:10 jamesfredley

Hey, @jamesfredley! Neither I nor the Geb project maintain this repository. For our part, we're actively working to move from this to Selenium Manager, which solves the same core problem. You can see the in-progress pull request for this at https://github.com/geb/geb/pull/200.

Even without that update to Geb, you can start using Selenium Manager by upgrading to Selenium 4.11 or later. It works just fine with the latest Geb release. I would recommend upgrading to the latest version of Selenium you can in your environment, as Selenium Manager did have a few bugs in the earlier iterations that are now resolved. That may entail Java updates, though, depending on your project.

Obviously, you can always use an artifact built from your fork here in the interim, and if @erdi wants to merge this here, more power to you both. :)

jonnybot0 avatar Oct 28 '24 14:10 jonnybot0

Thanks for the reply.

For Grails, we are moving the default Geb setup to use org.testcontainers:selenium via https://github.com/grails/geb/blob/7a50d0aa78671f41ce0237b98b501cf844208081/src/testFixtures/groovy/grails/plugin/geb/ContainerGebSpec.groovy#L49 which is working great.

This PR would help users that want to use Gradle 8.6+ with webdriver-binaries-gradle-plugin.

jamesfredley avatar Oct 31 '24 20:10 jamesfredley

Applied under new repository home: https://gitlab.com/ysb33rOrg/gradle/webdriver-binaries-gradle-plugin/-/commit/496223a64d3d6ad57e1139ad40c956384db3e2e7

jamesfredley avatar Oct 21 '25 13:10 jamesfredley