proteus icon indicating copy to clipboard operation
proteus copied to clipboard

Unify VOF, VOF3P and VOS3P

Open manuel-quezada opened this issue 7 years ago • 1 comments

This issue is to incorporate a recently implemented solver for the linear conservation law under non divergence free velocity fields. The idea is to apply subsequent FCT steps to impose global bounds based on a max saturated concentration. The first FCT is global and uses a discrete upwinded solution as target and the old solution as safeguard goal when the global upper bound is violated. Note that the target solution is positivity preserving and moreover MPP (thanks to discrete upwinding) but it doesn't satisfy the global upper bound. Afterwards, we consider a high-order discretization of the transport equation and apply standard Zalesak's FCT. The code is in VOF.h within mquezada/VOS. We want to:

  • Clean up the code.
  • Compare and discuss about unifying VOF, VOF3P and VOS3P.
  • Test the unified implementation specially for saturated flows.

manuel-quezada avatar Oct 26 '18 08:10 manuel-quezada

@manuel-quezada I believe where you got on this was that VOF3P should no longer be required. If that's true, than I think @adimako @acatwithacomputer and I just need to make sure we do all of our testing with VOF and not VOF3P, then just remove VOF3P. Can you confirm?

cekees avatar Jan 23 '19 19:01 cekees