proteus icon indicating copy to clipboard operation
proteus copied to clipboard

possible bug in Advection_ASGS df_last initialization

Open mfarthin opened this issue 11 years ago • 2 comments

Aron and I found this when reviewing the code. Looks like the ('df',ci,ci) key is missing

https://github.com/erdc-cm/proteus/blob/master/src/SubgridError.py#L76

    for ci in range(self.nc):
        if self.lag:
            self.tau_last.append(numpy.zeros(cq[('u',ci)].shape,'d'))
            self.tau.append(numpy.zeros(cq[('u',ci)].shape,'d'))
            if cq.has_key(('df',ci,ci)):
                self.df_last = copy.deepcopy(cq[('df',ci,ci)])
                cq[('df_sge',ci,ci)] = self.df_last

mfarthin avatar Oct 14 '14 22:10 mfarthin

OK, meaning at this stage cq doesn't have ('df',ci,ci) yet so we don't get a proper deepcopy?

cekees avatar Oct 14 '14 23:10 cekees

@cekees I can't find the file reference. Closing this. Probably the file has been moved (change of address). Close and reopen?

adimako avatar Jan 21 '19 17:01 adimako