proteus
proteus copied to clipboard
2D Analytic Geometry using PUMI
Mandatory Checklist
Please ensure that the following criteria are met:
- [ ] Title of pull request describes the changes/features
- [ ] Request at least 2 reviewers
- [ ] If new files are being added, the files are no larger than 100kB. Post the file sizes.
- [ ] Code coverage did not decrease. If this is a bug fix, a test should cover that bug fix. If a new feature is added, a test should be made to cover that feature.
- [ ] New features have appropriate documentation strings (readable by sphinx)
- [ ] Contributor has read and agreed with CONTRIBUTING.md and has added themselves to CONTRIBUTORS.md
As a general rule of thumb, try to follow PEP8 guidelines.
Description
Add the capability of circle in rectangle using parameterization API available through scorec/core (PUMI). A parameterization allows for mesh adaptation to snap onto the geometry properly, thereby enabling proper meshing for moving objects.
- [ ] Generalize functions to work with 2D and 3D interchangeably
- [ ] Need to add a test
Codecov Report
Merging #1217 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #1217 +/- ##
=======================================
Coverage 52.09% 52.09%
=======================================
Files 526 526
Lines 108803 108803
=======================================
Hits 56684 56684
Misses 52119 52119
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f338ae4...6f76661. Read the comment docs.