RAPIDpy icon indicating copy to clipboard operation
RAPIDpy copied to clipboard

Support NASA HIWAT and European COSMO weather prediction models

Open xhqiao89 opened this issue 6 years ago • 6 comments

NASA HIWAT model: https://ntrs.nasa.gov/archive/nasa/casi.ntrs.nasa.gov/20180003183.pdf

COSMO model: http://www.cosmo-model.org/

xhqiao89 avatar Apr 29 '19 20:04 xhqiao89

I am happy to see you contributing to RAPIDpy! A couple of things I would like to see before merging this in would be:

  1. Tests demonstrating that your additions work and to ensure stability moving forward.
  2. Your commit history squashed into logical groupings.

Thanks and please ask questions if you have any.

snowman2 avatar Apr 29 '19 20:04 snowman2

Also, adding to the documentation about the models supported.

snowman2 avatar Apr 29 '19 20:04 snowman2

@snowman2 This great project has benefited our research for years and we are glad to contribute to it. The preliminary PR is our first step on this right path. We will be updating the it to meet code standards and updating doc over the next few weeks. Thanks.

xhqiao89 avatar Apr 29 '19 21:04 xhqiao89

Sounds good 👍

snowman2 avatar Apr 29 '19 21:04 snowman2

I updated my author information in the commit history and it seems to have impacted this PR. You will need to rebase your branch to this repos master branch. A simpler approach may be to create a new branch from this repos master branch and cherry pick your changes into the new branch. Feel free to reach out if you have any questions. Thanks!

snowman2 avatar May 06 '19 02:05 snowman2

@snowman2 Thanks for the information.

xhqiao89 avatar May 06 '19 17:05 xhqiao89