erasure-protocol icon indicating copy to clipboard operation
erasure-protocol copied to clipboard

onlyPayloadSize should not be necessary with Solidity 0.5

Open fulldecent opened this issue 6 years ago • 1 comments

I learned the hard way that Solidity has stronger type safety. Because it broke the ERC-165 reference implementation. The function onlyPayloadSize seems to be testing for something that Solidity now automatically tests for.

Recommendation: review if onlyPayloadSize is necessary.

References:

  • Definition: https://github.com/erasureprotocol/erasure-protocol/blob/4a3d98ce023a264a9f3c7ba62ef77a9207bba5fe/contracts/helpers/mock/MockNMR.sol#L21

fulldecent avatar Nov 18 '19 16:11 fulldecent

Mock NMR should really be compiled with solc 0.4.11 in order to match the deployed token https://etherscan.io/address/0x1776e1f26f98b1a5df9cd347953a26dd3cb46671#code

Future improvement will be to modify compilation script to support multiple solidity versions

thegostep avatar Nov 20 '19 20:11 thegostep